Skip to content

Validate resource URI wire fields#262

Closed
leehack wants to merge 1 commit into
spec/elicitation-number-schema-boundsfrom
spec/resource-uri-validation
Closed

Validate resource URI wire fields#262
leehack wants to merge 1 commit into
spec/elicitation-number-schema-boundsfrom
spec/resource-uri-validation

Conversation

@leehack

@leehack leehack commented Jun 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • validate stable and draft resource URI fields as absolute URI strings at parse and serialization boundaries
  • validate resource URI template fields with stricter RFC 6570 variable checks
  • update tests, changelog, and stdio example fixture to use spec-valid resource URIs

Validation

  • dart analyze
  • git diff --check
  • dart test
  • dart pub global run coverage:test_with_coverage
  • dart test test/types/resources_test.dart test/shared/uri_template_test.dart test/mcp_2025_11_25_test.dart test/mcp_2026_07_28_test.dart
  • dart test test/example/non_credentialed_examples_smoke_test.dart -p vm --plain-name "non-credentialed examples smoke tests stdio client drives stdio server tools resources and prompts"
  • dart test test/server/server_test.dart --plain-name "Server can send resource notifications when capability is registered"
  • dart test test/server/server_test.dart --plain-name "Server cannot send notifications when capability is not registered"
  • dart test test/interop/dart_client_with_ts_server_test.dart --reporter expanded

Stacked on #261; this RC spec stack stays off main until the final spec release.

@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.20635% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.70%. Comparing base (f33a4ca) to head (4e1b6f3).

Files with missing lines Patch % Lines
lib/src/types/validation.dart 95.83% 1 Missing ⚠️
Additional details and impacted files 
@@                            Coverage Diff                            @@
##           spec/elicitation-number-schema-bounds     #262      +/-   ##
=========================================================================
+ Coverage                                  88.62%   88.70%   +0.07%     
=========================================================================
  Files                                         47       47              
  Lines                                       9498     9563      +65     
=========================================================================
+ Hits                                        8418     8483      +65     
  Misses                                      1080     1080
Flag Coverage Δ
unittests 88.70% <99.20%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leehack leehack mentioned this pull request Jun 1, 2026
Closed
@leehack

leehack commented Jun 1, 2026

Copy link
Copy Markdown
Owner Author

Closing this draft micro PR because the RC spec work has been consolidated into a smaller reviewable stack. This change is preserved in #271 (type/schema validation); the consolidated tip is tree-identical to the previous micro-stack tip.

@leehack leehack closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@leehack